rust-s3 icon indicating copy to clipboard operation
rust-s3 copied to clipboard

Feature tokio-rustls-tls requires native-tls?

Open emmiegit opened this issue 8 months ago • 5 comments

Describe the bug I'm looking at feature flag definition in Cargo.toml and the dependencies in Cargo.lock, and I noticed that the tokio-rustls-tls feature depends on native-tls, rather than using rustls. This would explain build issues I am facing due to the compilation trying to look for an openssl which isn't there.

I am noticing that the with-tokio feature in the flag list requires tokio-native-tls, native-tls, etc., whereas previously with-tokio only required ["reqwest", "tokio", "tokio/fs", "tokio-stream"]. This seems to preclude any possibility of using Tokio with rustls, despite what the feature flag list would suggest.

See 0.32.3's Cargo.toml compared to 0.34.0's.

Why does using Tokio require native TLS? Is there a way I can use only rustls instead alongside Tokio?

Environment

  • Rust version: 1.79.0
  • lib version 0.34.0

Additional context This issue occurred when trying to upgrade to 0.34.0. See https://github.com/scpwiki/wikijump/pull/1962.

emmiegit avatar Jun 28 '24 06:06 emmiegit