webamp-desktop icon indicating copy to clipboard operation
webamp-desktop copied to clipboard

Replace temporary custom webamp bundle and add macos media keys

Open durasj opened this issue 5 years ago • 3 comments

All ideas come from the @captbaritone.

durasj avatar Mar 17 '19 20:03 durasj

Are you running type checking on Travis? I would expect this to fail type checking since track.defaultTitle is not present on the argument passed to the onTrackDidChange callback.

Also, there are some @ts-ignore comments in src/renderer.ts which can probably be cleaned up.

captbaritone avatar Mar 17 '19 22:03 captbaritone

Looks good!

captbaritone avatar Mar 17 '19 22:03 captbaritone

@captbaritone

Are you running type checking on Travis? I would expect this to fail type checking since track.defaultTitle is not present on the argument passed to the onTrackDidChange callback.

Unfortunately, no, parcel won't report those currently to me. I plan to change that later together with a rewrite of the main process part to the TS. Thanks for the heads up, is there please now any alternative to the defaultTitle?

Also, there are some @ts-ignore comments in src/renderer.ts which can probably be cleaned up.

Ah, right, done :)

Thank you very much for checking this!

durasj avatar Mar 17 '19 22:03 durasj