webamp-desktop
webamp-desktop copied to clipboard
Replace temporary custom webamp bundle and add macos media keys
All ideas come from the @captbaritone.
Are you running type checking on Travis? I would expect this to fail type checking since track.defaultTitle is not present on the argument passed to the onTrackDidChange
callback.
Also, there are some @ts-ignore
comments in src/renderer.ts
which can probably be cleaned up.
Looks good!
@captbaritone
Are you running type checking on Travis? I would expect this to fail type checking since track.defaultTitle is not present on the argument passed to the
onTrackDidChange
callback.
Unfortunately, no, parcel won't report those currently to me. I plan to change that later together with a rewrite of the main process part to the TS. Thanks for the heads up, is there please now any alternative to the defaultTitle?
Also, there are some
@ts-ignore
comments insrc/renderer.ts
which can probably be cleaned up.
Ah, right, done :)
Thank you very much for checking this!