Bryan

Results 19 comments of Bryan

- `newTemplateModelId` and `newTemplateActivityTypes` stores are probably unnecessary as it's not being reused across other components - the activity type subscription can be converted to just a request made within...

Some additional UI work would be needed to handle cases when the model arguments schema changes. Specifically, we need a way to clear out any extraneous arguments. This would work...

Finding from @sqlAlchemyNoob2004: > Plans page susceptible to client side latency spikes if there is a lot of websocket traffic. While the server appears to handle high load, an individual...

@Mythicaeda all comments shooould be addressed finally. Thanks for taking a look!

@parkerabercrombie thanks for trying it out in the new workspaces! While there is still a lot more work in store for workspaces, I believe there is no more work needed...

@sqlAlchemyNoob2004 Yeah, `getActivitiesForPlan` is more for getting the activities for the plan more immediately for processing plan export, whereas the subscription is to handle updates after loading the plan view....

@sqlAlchemyNoob2004 nice find! My suspicion is it has something to do with https://github.com/NASA-AMMOS/aerie-ui/blob/develop/src/components/sequencing/SequenceEditor.svelte#L126. Might need to make more granular reactive statements to not capture unnecessary updates to svelte states.

@parkerabercrombie Is a relevant model selected and the linting errors are still showing?