phosphor-react-native icon indicating copy to clipboard operation
phosphor-react-native copied to clipboard
verified publisher icon duongdev

New Icons

Open TonySilva7 opened this issue 1 year ago • 4 comments

There are new icons for the web version. Is there any prospect of adding them to the React Native version?

TonySilva7 avatar Apr 25 '24 22:04 TonySilva7

Hi @jhhayashi can you check this please?

mrkpatchaa avatar May 27 '24 08:05 mrkpatchaa

I would love this too – I did attempt to make a PR to do it myself, but I couldn't figure out how to update them 🙈 May revisit it when I get a chance though.

shaundon avatar Jun 20 '24 08:06 shaundon

@shaundon the generated icons are not in the repository anymore. Someone with NPM credentials needs to run the generate script and then release it to NPM. @jhhayashi has been granted access by @duongdev back in 2023. Check the discussion here: https://github.com/duongdev/phosphor-react-native/pull/33

mrkpatchaa avatar Jun 20 '24 10:06 mrkpatchaa

Ah, thanks for the extra context!

shaundon avatar Jun 20 '24 10:06 shaundon

This package is updated https://www.npmjs.com/package/react-native-phosphor?activeTab=versions

hadnet avatar Aug 07 '24 05:08 hadnet

@hadnet it's unfortunate that we need to duplicate packages just for an update. I remember I've created one myself when upgrading icons (deleted now) Now the update to NPM takes barely 5 min, but no maintainer here can do it 😞 @jhhayashi @duongdev can you please add more people as maintainers and explain how to publish new updates? Thanks.

mrkpatchaa avatar Aug 07 '24 08:08 mrkpatchaa

@mrkpatchaa I am happy to. Do you want to give a help?

duongdev avatar Aug 07 '24 08:08 duongdev

@duongdev Yes I can help. Thanks.

mrkpatchaa avatar Aug 07 '24 21:08 mrkpatchaa

@mrkpatchaa Added you as repo's collaborator. Please send me your npmjs username as well

duongdev avatar Aug 08 '24 04:08 duongdev

Hi @duongdev my username is mrkpatchaaadmin. You can also try with my email [email protected]

mrkpatchaa avatar Aug 08 '24 13:08 mrkpatchaa

@mrkpatchaa Added you as contributor. Please help to update the package. Thank you very much!

duongdev avatar Aug 09 '24 15:08 duongdev

@duongdev it seems like I cannot push to main. Can you check please? Version 2.1.0 published on NPM https://www.npmjs.com/package/phosphor-react-native/v/2.1.0

mrkpatchaa avatar Aug 09 '24 16:08 mrkpatchaa

@mrkpatchaa Thank you very much! Btw, you might need to open a PR to main instead of commit directly.

duongdev avatar Aug 13 '24 17:08 duongdev