webauthn icon indicating copy to clipboard operation
webauthn copied to clipboard

build: update to Go 1.18

Open Juneezee opened this issue 4 years ago • 5 comments

This PR introduces two changes:

  1. Updates the go directive in go.mod file by running go mod tidy -go=1.17 to enable module graph pruning and lazy module loading.
  2. Update GitHub Actions go.yml to Go 1.17

Note 1: This PR does not prevent users with earlier Go versions from successfully building packages from this module.

Note 2: The additional require directive is used to record indirect dependencies for Go 1.17 or higher, see https://go.dev/ref/mod#go-mod-file-go.

Juneezee avatar Dec 25 '21 05:12 Juneezee

👍

nicksteele avatar Feb 23 '22 18:02 nicksteele

Perhaps we bump this to 1.18 now that 1.17 is no longer supported and try to get it merged?

aseigler avatar Aug 14 '22 01:08 aseigler

@aseigler Updated to Go 1.18. Please take a look again, thank you :smiley:

Juneezee avatar Aug 14 '22 05:08 Juneezee

I think this is ready to merge @MasterKale unless anyone has objections? This is what is breaking actions currently.

aseigler avatar Aug 14 '22 20:08 aseigler

I just first-time contributor actions, I think those have to run? Mobile doesn't show that real well so I'll check later today when I get back in front of a computer. If everything looks fine there I'll merge.

MasterKale avatar Aug 14 '22 22:08 MasterKale

Merging despite test failures, it's @aseigler's fault if it breaks a bunch of stuff (and mine if it fixes them all) :shipit:

MasterKale avatar Aug 15 '22 18:08 MasterKale