dunst-project
Add navigation for clickable menu
Hello fellow geeks,
I add key navigation inside of notification:
- left, right, up and down arrow keys select the button (action)
- enter key executes action
- add “focus“ when selected, the first key is the default focus key
I tested it in Wayland, hope this makes the built-in menu more user-friendly.
This PR is based on #1436, which introduces a built-in clickable menu feature.
Additionally, since this functionality depends on libxkbcommon, I have added it to the CI Docker image in dunst-project/docker-images#16.
i added libxkbc to the dockerfiles. ci looks good, the only problem is something with doxygen
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
:x: Patch coverage is 4.37500% with 306 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 62.83%. Comparing base (068e4e9) to head (079185e).
:warning: Report is 12 commits behind head on master.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| src/draw.c | 12.61% | 97 Missing :warning: |
| src/menu.c | 0.00% | 95 Missing :warning: |
| src/wayland/wl_seat.c | 0.00% | 62 Missing :warning: |
| src/input.c | 0.00% | 48 Missing :warning: |
| src/queues.c | 0.00% | 4 Missing :warning: |
| :exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality. |
Additional details and impacted files
@@ Coverage Diff @@
## master #1480 +/- ##
==========================================
- Coverage 64.90% 62.83% -2.07%
==========================================
Files 51 51
Lines 9024 9337 +313
Branches 1048 1128 +80
==========================================
+ Hits 5857 5867 +10
- Misses 3167 3470 +303
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 62.83% <4.37%> (-2.07%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
This PR is based on #1436, containing a lot of the same code. However it uses totally different commits. This means that if #1436 is merged, this PR would likely have a lot of merge conflicts. I suggest either dropping #1436, because this all of its functionality, or properly rebasing on this PR (which would involve some git trickery).
I originally proposed to split the menu button and this pr since this added libxkd dependency. I think the best course is to merge the other pr first and then rebase this one on top of it.
I originally proposed to split the menu button and this pr since this added libxkd dependency. I think the best course is to merge the other pr first and then rebase this one on top of it.
Yeah, that could work