dunst icon indicating copy to clipboard operation
dunst copied to clipboard

Don't search for icon path if icons are disabled

Open bynect opened this issue 1 year ago • 2 comments

Close #1114

bynect avatar Mar 01 '24 23:03 bynect

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 65.06%. Comparing base (15b1e8c) to head (8ca7f8e). Report is 2 commits behind head on master.

Files Patch % Lines
src/notification.c 75.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1301   +/-   ##
=======================================
  Coverage   65.06%   65.06%           
=======================================
  Files          48       48           
  Lines        8173     8173           
=======================================
  Hits         5318     5318           
  Misses       2855     2855           
Flag Coverage Δ
unittests 65.06% <75.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Mar 01 '24 23:03 codecov-commenter

This should work unless you can enable icons to an old notification with disabled icons. Because at that point the notification wouldn't have loaded the icon. However I don't think there is a way to change icon_position between creation and display (?)

bynect avatar Mar 04 '24 23:03 bynect