symfony-docker icon indicating copy to clipboard operation
symfony-docker copied to clipboard

"Installing on an Existing Project" is missing a step

Open KableCH opened this issue 5 months ago • 2 comments

The docs page for Installing on an Existing Project is missing a step.

The problem

When following the guide, the app container does not start correctly because the dependency runtime/frankenphp-symfony is missing. When using the template directly, this is not the case because the dependency gets installed in here.

My suggestion

Adding the following after step "Re-execute the recipes to update the Docker-related files according to the packages you use":

    Add frankenphp runtime for Symfony:
    
    composer require runtime/frankenphp-symfony

I created pull request #810 for this issue. Thank you!

KableCH avatar Jun 25 '25 09:06 KableCH

Hi @KableCH!

Good catch! The documentation currently describes the runtime/frankenphp-symfony package as optional. Although without this package or without disabling worker mode, the project will not start.

IMO it would make more sense to remove the note about the optionality of the package, moving it to the steps (as you suggest). And the note about disabling worker mode can be supplemented with information about the possibility of removing the runtime/frankenphp-symfony package.

WDYT?

7-zete-7 avatar Jun 25 '25 09:06 7-zete-7

I agree! I pushed a new version. Let me know what you think!

KableCH avatar Jun 25 '25 11:06 KableCH