symfony-docker icon indicating copy to clipboard operation
symfony-docker copied to clipboard

fix: php ini loading order

Open wizhippo opened this issue 1 year ago • 5 comments

https://github.com/dunglas/symfony-docker/issues/538

As php takes the last ini value set, in frankenphp/conf.d

The order currently is:

app.dev.ini app.ini

Expected would be:

app.ini app.dev.ini

This renames app.dev.ini to app.zzz-dev.ini so it is loaded last.

wizhippo avatar Mar 21 '24 19:03 wizhippo

Perhaps need to be changed again so both app.ini and app.dev.ini are both loaded after all others?

app.ini -> zzz-app.ini add.dev.ini -> zzz-dev.ini

wizhippo avatar Mar 21 '24 20:03 wizhippo

Maybe 01- and 02- ?

dunglas avatar Mar 21 '24 21:03 dunglas

#538

I commented in the issue but won't leading with numbers load before any docker-php-ext-xyz.ini configs? Normally do we not want app to supersede those too? That's why I choose the zzz prefix. Also in the case of zzz-dev.ini, that seems more likely to be always last. even if adding other user config files.

wizhippo avatar Mar 21 '24 21:03 wizhippo

Yes, you're right. So we need something that passes after docker-php-ext. What do you think about renaming app in php in this case for files to come after extensions and then choosing how to put the dev last?

maxhelias avatar Mar 22 '24 08:03 maxhelias

I've opened another PR #617 based on my comment in #538.

leroy0211 avatar Apr 25 '24 21:04 leroy0211