react-esi

react-esi copied to clipboard

Feat: migrate to Github Actions

5

Related: #31

Fabious

Feat: replace tslint with eslint and update linting

2

Fabious

Travis doesn't work anymore, we must migrate to GitHub Actions.

dunglas

This Pull Request only change in README.md ReactJs Example from Class Component to Functional Component.

jrmarqueshd

prop-types should be a dependency

1

Regarding the official usage of `prop-types`: https://github.com/facebook/prop-types#how-to-depend-on-this-package, its needs to be a `dependencies` instead of `devDependencies`. I would propose a PR if you like.

bobaaaaa

next.js example was removed from upstream next.js project

3

The example, which is currently linked in the react-esi readme, no longer exists: https://github.com/zeit/next.js/blob/canary/examples/with-react-esi/ Is there a reason this was removed? i.e., something about it doesn't work correctly? Or has...

milesrichardson

Is there any downsides of opting-out from default Next.js server? On Next.js website it's [stated](https://nextjs.org/docs/advanced-features/custom-server): >Before deciding to use a custom server please keep in mind that it should only...

oogxdd

How to get and serve HTML fragments?

3

I was wondering how can I render an HTML fragment which is not a component... For example: Let's say that `example.com/esi-fragment` is serving ``` content ``` So, as per ESI...

napolux

Handling complex project structure

1

Two pieces of the README first: **withESI usage:** const MyFragmentESI = withESI(MyFragment, 'MyFragment'); // The second parameter is an unique ID identifying this fragment. // If you use different instances...

VincentCharpentier

Context is not passed to catch store for ssr?

aiwbend