frankenphp icon indicating copy to clipboard operation
frankenphp copied to clipboard

Add docs for custom docker image

Open alexander-schranz opened this issue 2 years ago • 4 comments

I'm missing something like this in the docs.

alexander-schranz avatar Oct 31 '22 15:10 alexander-schranz

Can't we merge this with the existing docs about Docker in a "Docker" section?

dunglas avatar Oct 31 '22 16:10 dunglas

@dunglas Yeah I was not sure to mix them up. I think the currenlty docker.md is focused for Contributers or Maintaincers of FrankenPHP not about the one using it.

I even think worker.md linked as The worker mode is misleading and should be called Getting Started instead or Using FrankenPHP and then maybe add it there?

Also I personally more a fan to have one bigger doc file instead of splitting the docs into multiple files make searching for specific things easier and think why also Symfony merged a lot of docs together in the last years.

What do you think?

alexander-schranz avatar Oct 31 '22 16:10 alexander-schranz

I was also thinking about docs like this. But this is really different thing than the current content of docker.md.

Maybe something like "Extending FrankenPHP" ?

back-2-95 avatar Oct 31 '22 18:10 back-2-95

Or just a new section at the end: "Creating Your Own Images"?

dunglas avatar Nov 01 '22 00:11 dunglas

Thank you @alexander-schranz!!

dunglas avatar Nov 03 '22 08:11 dunglas