Kévin Dunglas

Results 1072 comments of Kévin Dunglas

Can we merge this one @nicolas-grekas?

The header is invalid. A space is missing after the colon. Does FPM correct that automatically?

What was the previous PHP environment? Were the headers sent to the client or just ignored? We display this log on purpose to be able to catch these kinds of...

Ok, with NGINX+FPM clients weren't receiving the header right? So we can close as this works as expected.

Il, I wasn't aware of this. PR welcome, it should be an easy fix (I'll do it when I'll be back from vacation if still needed)

It looks like Go doesn't ltrim the value, so we should do it: https://cs.opensource.google/go/go/+/refs/tags/go1.23.6:src/net/textproto/header.go;l=13 Also, in the spec it's stated that headers can be on multiple lines if the extra...

I'm not in favor of printing a warning. To me, the current behavior is expected and desirable when using the embedded app feature.

Unfortunately that will take too long on GitHub Actions. To do so we'll likely have to rent and maintain our own build machines. That's not planned yetW However, Docker images...

Regarding your issue, is there any error in the logs? Don't hesitate to copy the full output.

That's weird, xcaddy should install automatically. Can you try again after having run `go install xcaddy`?