Kévin Dunglas

Results 1072 comments of Kévin Dunglas

What do you think about just skipping the initial bound check in `callbackUpdateSystemStack` if we're in a thread that isn't managed by Go? This would fix both this issue and...

@cherrymui [CL 600296](https://go.dev/cl/600296) fixes this issue with FrankenPHP: https://github.com/dunglas/frankenphp/actions/runs/10091715703/job/27903861001?pr=938 🎉

I'm hesitating. I would prefer keeping the "general" Caddy-related options in sync with what native Caddy commands provide. What do you think @mholt @francislavoie?

That's weird, the URL resolves for me, but it's a redirection, that's maybe the issue.

Hi, see https://github.com/mfhepp/goodrelations/issues/1#issuecomment-2423945524 PR welcome to fix the tests!

Hi, I currently never tried to compile on FreeBSD, so there might be many issues like that. I would likely merge patch fixing them!

You need to compile PHP with ZTS support (and some other options) to use FrankenPHP: https://frankenphp.dev/docs/compile/#linux These are Linux instructions, but they also work on FreeBSD. For Brotli, it's to...

You need to keep the empty `frankenphp` directive.

Thanks for the feedback. Would you mind opening a PR to add the needed header include? IMHO, it will be easier to "manually" compile PHP from sources with ZTS enabled...