dune-client

dune-client copied to clipboard

This parameter should default to 1 hour and I am unsure if it specifies how long we want to wait for the function to run or if it means how...

bh2smith

I am not sure this is necessary... also makes all the function variables much longer. Can we use `exec_id`? I still prefer `job_id`.

bh2smith

max datapoints default param

8

For new teams and users, we've instituted a max datapoints of 250,000 as default so that they don't spend too many credits on accident. This is configurable in their Dune...

andrewhong5297

this actually works perfectly for python >= 3.10 ```py # Decorator to skip write on empty data sets. # TODO - this cool decorator only works for python >= 3.10...

bh2smith

Should probably be about here. https://github.com/cowprotocol/dune-client/blob/72718229c6507049d95a4f5c68b018aae529efca/dune_client/client.py#L129-L133 Might also be a good time to replace the generic "Exception" here with something less broad.

bh2smith

Query Hash is not deterministic!

2

between different runs, the hash function uses different seeds. So just be aware that it is deterministic in a single run, but not between different executions. https://github.com/cowprotocol/dune-client/blob/55d5f92f5436ad5b4fc18d7c050a01f463fce017/dune_client/query.py#L37-L42 TODO 1. Document...

bh2smith

I find these multi-line imports look a bit ugly and could probably be solved by some reexporting in the `__init__.py` file: ``` from dune_client.client import DuneClient from dune_client.query import Query...

bh2smith

pandas' `read_csv` does not properly read the string if it contains these unicodes and the string is discarded instead it either should be stripped on dune side or maybe there...

gosuto-inzasheru

Johnson1s

When querying a field that is a list, the response returns it as a single string with space-separated values, like: - [item item item] Instead of a valid JSON array...

f-resende