Duncan

Results 278 comments of Duncan

> Yes `auto` could be ok here, because the type is already written on the right side. > > ```c++ > auto &g_waterSettings = Make_Global(PICK_ADDRESS(0x00A2F0B8, 0x00A2F0B8)); > ``` > >...

After further testing I can confirm it would compile but only if we didn't forward declare so basically we can't do it that way.

Even with how much of a mouthful the definition ends up being?

> We could keep definitions macros just to keep some of the duplicate type and size declarations to a minimum? At least we don't need the helper structs anymore. The...

Note: Replays in this PR are no longer valid #19068 has had replays made for it. When a new scream has been chosen replays will need to be redone again.

I would expect it would still be happening. We don't change what sort of mouse selection mode we use depending on view mode.

Yup looks like its all addressed.

Yes pretty much same as what aaron said. We have two game state structures the s5 one that doesn't have type info (it's all just uintx) and the main one....

okay good luck. This is very complex.

I'm not a fan of them either but my issues with them are more a problem if every platform was using them.