Avenger Vengeance Mark and Avesta interaction causing lethal damage to be returned
From Pinkie: https://www.youtube.com/watch?v=O7Mxq6lu0A8
https://github.com/dun1007/fateanother/blob/master/game/dota_addons/fateanother/scripts/vscripts/addon_game_mode.lua#L1822
if (victim:HasModifier("modifier_verg_avesta") or victim:HasModifier("modifier_endless_loop")) and (victim:GetHealth() - damage) > 0 then
In the DamageFiler, it checks if victim:GetHealth() - damage > 0 which is fine. I'll assign some numbers to make this easier to see.
- Avenger's HP 1000
- damage dealth to him 900
- reflected damage 900
- damange source HP 800
- Vengeance mark return damage 120
The damage dealt to Avenger is reflected, it kills the damage source. This causes the Vengeance Mark modifier to be removed, triggering OnVengeanceEnd. This does damage to Avenger, before he has taken damage from the first damage filter. His HP drops below 0 after damage from the first DamageFilter is applied and he is killed, but the damage source has died first.
http://i.imgur.com/2HqbqjX.jpg