Ruler Flag Lock and Root interactions

[gelguy]

Destroying the flag does not remove the Root and Lock modifiers.

https://github.com/dun1007/fateanother/blob/bf44cdbd721138cddec80eddfd6f4f0452cfbd75/game/dota_addons/fateanother/scripts/vscripts/jeanne_ability.lua#L261-L269

Casting the flag (AbilityPhaseStart) causes Root and Lock modifiers (including modifiers from other spells e.g. Tamamo's W) to be removed from targets which were hit by the previous flag.

[dun1007]

Modifier removal at windup is intended to prevent infinite lockdown with reset. Flag needs to be fixed though.

[gelguy]

My concern is that the modifiers are removed during the cast animation. This means that even if you canceled the cast, the modifiers will be removed. Not only that, you may have cast the flag a round ago (and so the modifiers are gone already), but the previous targets still remain the same so their modifiers are removed while u cast.

Just to confirm again, is this meant to remove all roots and locks? This seems rather unintuitive as this means if you try to lock people down at the end of flag with say an S scroll, the duration is cut short.