Braulio Dumba

Results 40 comments of Braulio Dumba

> The combination of _add_ semantics and overlooked variables in the exhibited commands is quite toxic. I means that I build up a collection of broken ec2 instances. I believe...

> Is the following what I should see? I see machines doing double-duty. I see the one WEC machine mixed in with the core machines. > > ``` > mspreitz@mjs13...

> I have finished my review of commit [4c8ed2a](https://github.com/kubestellar/kubestellar/commit/4c8ed2aa507db13c4e25ba505abb0842313145d8); made comments in GitHub and in Slack. @MikeSpreitzer, I just pushed all the changes that addresses all your comments. This PR...

> I am still seeing unqualified filenames in .data Did you start from a cleaning env. Do you have old files from previous run?

> Testing commit [b00fdae](https://github.com/kubestellar/kubestellar/commit/b00fdae41b4883c9af6c171759c855153fb6fe08), starting with empty .data, I successfully ran through the setup in INSTRUCTIONS.md. I still see unqualified file and directory names: > > ``` > bash-3.2$ ls...

> The region&vpc specific directory structure shown above looks good. I see that the region is duplicated in one filename; not a functional problem, just unnecessary. We need to keep...

> I have finished my review of commit [b00fdae](https://github.com/kubestellar/kubestellar/commit/b00fdae41b4883c9af6c171759c855153fb6fe08) @MikeSpreitzer, I have addressed all your comments. This PR is ready for another look. Thanks!

> #2534 @MikeSpreitzer (cc: @krrish-sehgal ), I just added some clarification comments in #2534

> Thanks. I posted some follow-up questions. @MikeSpreitzer, thanks, I just added some new comments and questions.

@antedotee, I see test failing on this PR. Could you fix it? thanks!