Results 113 issues of dullbananas

* Create a new `build_db_pool_for_tests` function which: * Builds the pool in a `LazyCell` which runs migrations and maybe inserts stuff in the initialization function * Gets a pooled connection,...

area: database
area: maintenance

A more efficient way is to check for the diesel `DatabaseErrorKind::UniqueViolation` variant and choose the right `LemmyError` variant using the `DatabaseErrorInformation::column_name` variant

area: performance
area: database

This is cleaner than having this condition wherever the functions are called

area: maintenance

`#[diesel(skip_insertion)]` would go on the field

area: maintenance

### Requirements - [X] Is this a feature request? For questions or discussions use https://lemmy.ml/c/lemmy_support - [X] Did you check to see if this issue already exists? - [X] Is...

enhancement
area: notifications
area: email

Including the `pkgutil --expand InstallMacOSX.pkg tempdir` command

In my opinion, resolving merge conflicts is a bigger inconvenience than seeing tall imports.

area: maintenance

See my reviews of #4977 for examples. Searching for `is_ok`, `is_ok_and`, and `if let Ok` should reveal most of the wrong error handling.

area: database
area: maintenance

### Requirements - [X] This is a feature request and not a bug report. Otherwise, please create a new [bug report](https://github.com/LemmyNet/lemmy-ui/issues/new?assignees=&labels=bug%2Ctriage&projects=&template=BUG_REPORT.yml) instead. - [X] Please [check](https://github.com/LemmyNet/lemmy-ui/issues) to see if this...

enhancement