Userscripts icon indicating copy to clipboard operation
Userscripts copied to clipboard

iTunes import broken after redesign

Open liftarn opened this issue 7 years ago • 40 comments

It appears the redesign broke the script.

liftarn avatar Jun 08 '17 11:06 liftarn

@liftarn @augustjanse I've updated the script and it now works for me. Please try and let me know!

dufferzafar avatar Jun 09 '17 06:06 dufferzafar

I can't see the importation button on any pages after the new design. https://itunes.apple.com/fr/album/witness/id1236471560 image

ewauq avatar Jun 09 '17 08:06 ewauq

Sorry, but I don't see the import button either.

liftarn avatar Jun 10 '17 09:06 liftarn

OK. This is weird since it works for me :confused:

https://itunes.apple.com/fr/album/witness/id1236471560 image

https://itunes.apple.com/us/album/best-of-kailash-kher/id420713987 image

dufferzafar avatar Jun 10 '17 15:06 dufferzafar

How can we debug this now?

dufferzafar avatar Jun 10 '17 15:06 dufferzafar

Just deleted the userscript and re-installed it, same problem for me. This is the only Userscript I activated. image

ewauq avatar Jun 10 '17 15:06 ewauq

Hi, considering that the "Link to HD Artwork" is working, I've moved the "Add to MusicBrainz" button to the left now. And have updated the script accordingly. See if this works.

image

dufferzafar avatar Jun 10 '17 17:06 dufferzafar

Odd. I first saw the Link to HD Artwork button, but then it vanished. It may be an idea to bump the version as well.

liftarn avatar Jun 11 '17 08:06 liftarn

@liftarn When that happens, did you try and reload the page? It happened for me too once but I reloaded and it worked!

dufferzafar avatar Jun 11 '17 11:06 dufferzafar

Hmm, it's not working for me either, even after the latest update. The link to HD artwork works (links only to the 939px version and not 1200px) but the import button is just not there (like liftarn and ewauq). I'm using Tampermonkey and Google Chrome 60.0.3112.24 an macOS 10.12.5.

V-Toll avatar Jun 11 '17 14:06 V-Toll

hey it don't work me.

Bacardi89 avatar Jun 11 '17 18:06 Bacardi89

@dufferzafar Nope, just the artwork link first showing and then disappearing. Running Greasemonkey 3.11 on Firefox.

liftarn avatar Jun 12 '17 07:06 liftarn

I still haven't managed to get it to work using Firefox 54.0 and GreaseMonkey 3.11. I have tried to reinstall both the script and GreaseMonkey with no luck.

liftarn avatar Jun 19 '17 14:06 liftarn

Did you check your console (Ctrl+Shift+K)? My update should have fixed the error visible in @ewauq's screenshot, if your console shows a different one that would be helpful. Also try refreshing the release page, seems like it can be a little slow in showing up.

augustjanse avatar Jun 19 '17 15:06 augustjanse

Noting really suspicious in the console: Cross-Origin begäran blockerad: Same-Origin policyn tillåter inte läsningar av fjärresurs på https://www.apple.com/ac/globalfooter/3/en_US/assets/ac-footer/legacy/appleicons_text.woff. (Orsak: CORS header 'Access-Control-Allow-Origin' saknas). (okänt) downloadable font: download failed (font-family: "Apple Legacy Chevron" style:normal weight:normal stretch:normal src index:1): bad URI or cross-site access not allowed source: https://www.apple.com/ac/globalfooter/3/en_US/assets/ac-footer/legacy/appleicons_text.woff ac-globalfooter.built.css:1:1040 Metrics config: No config provided via delegate or fetched via init(), using default/cached config values. vendor-5f048e2ad0248e8169016946294565f8.js:28:11988 Cross-Origin begäran blockerad: Same-Origin policyn tillåter inte läsningar av fjärresurs på https://www.apple.com/ac/globalfooter/3/en_US/assets/ac-footer/legacy/appleicons_text.ttf. (Orsak: CORS header 'Access-Control-Allow-Origin' saknas). (okänt) downloadable font: download failed (font-family: "Apple Legacy Chevron" style:normal weight:normal stretch:normal src index:2): bad URI or cross-site access not allowed source: https://www.apple.com/ac/globalfooter/3/en_US/assets/ac-footer/legacy/appleicons_text.ttf ac-globalfooter.built.css:1:1040 GET https://web-experience.itunes.apple.com/assets/controls/[email protected] [HTTP/1.1 200 OK 0ms] OPTIONS XHR https://xp.apple.com/report/2/xp_its_preview [HTTP/1.1 200 OK 522ms] POST XHR https://xp.apple.com/report/2/xp_its_preview [HTTP/1.1 200 OK 138ms]

liftarn avatar Jun 20 '17 06:06 liftarn

When refreshing I sometimes get a "Link to HD artwork" that then disappear.

liftarn avatar Jun 20 '17 06:06 liftarn

Replication succeeded! Windows 10, newly installed Firefox 54.0 64-bit and Greasemonkey 3.11 for the record, but the browser is probably the critical part. I'll take a look.

augustjanse avatar Jun 20 '17 07:06 augustjanse

Tested with your fix and it seem to solve the problem.

liftarn avatar Jun 20 '17 12:06 liftarn

This is still broken for me. Link to HD artwork and import button appear briefly below the artwork, then disappears. Firefox 55, Linux

libussa avatar Aug 19 '17 10:08 libussa

@libussa Link to itunes page where you're experiencing the problem?

A screenshot?

dufferzafar avatar Aug 19 '17 16:08 dufferzafar

@dufferzafar everything I tried is problematic. A couple of examples: https://itunes.apple.com/us/album/good-will-continue-remixes/id1266082650 https://itunes.apple.com/fr/album/bubbling/id1205433832

screenshot: https://i.imgur.com/eZKvKkr.png

libussa avatar Aug 19 '17 17:08 libussa

Yes, it appears and then disappears. Using Firefox 54.0.1 and Greasemonkey 3.11

liftarn avatar Aug 22 '17 06:08 liftarn