duffel-api-python icon indicating copy to clipboard operation
duffel-api-python copied to clipboard

Always raise a more specific exception than Exception

Open richcooper95 opened this issue 3 years ago • 0 comments

Describe the bug In some places, Exception is raised - this isn't good practice as it makes it almost impossible for the users of the library to catch this specific exception without hiding bugs - see discussion here.

To Reproduce n/a

Expected behavior It’s much better to define a custom Exception class, or use one of the built-ins (e.g. RuntimeError).

Examples around here - in this case, InvalidResponseError might be a better exception type.

System (please complete the following information): n/a

Additional context n/a

richcooper95 avatar Feb 02 '22 16:02 richcooper95