imap-codec icon indicating copy to clipboard operation
imap-codec copied to clipboard

Improve handling of MSRV

Open jakoschiko opened this issue 1 year ago • 4 comments

Ideas:

After these steps there is only a single place that defines the MSRV.

jakoschiko avatar Nov 12 '24 23:11 jakoschiko

Superseeded by https://github.com/duesee/imap-codec/issues/616

duesee avatar Nov 13 '24 14:11 duesee

Superseeded by #616

Are you sure? That might cause a stack overflow.

jakoschiko avatar Nov 15 '24 00:11 jakoschiko

I... uhm... I guess this is what happens when you comment with a flaky Internet connection. No idea what happened.

duesee avatar Nov 15 '24 01:11 duesee

Relates to #534

jakoschiko avatar Nov 18 '24 18:11 jakoschiko

cargo read-manifest requires a non-virtual manifest (and is deprecated). We can add it to imap-codec/imap-typess Cargo.toml and read it via ...

cargo metadata --format-version=1 --no-deps | jq -r '.packages[] | select(.name == "imap-codec") | .rust_version

Nit: The rust_version in imap-codec would be used here and the one from imap-types could potentially be different... It's still an improvement.

Nit: We need jq as build dependency and I'm too lazy to document it. WHY CANT EVERYBODY JUST USE nix develop?! Joking :-)

duesee avatar Sep 06 '25 19:09 duesee

Done in #662.

duesee avatar Sep 07 '25 09:09 duesee