imap-codec icon indicating copy to clipboard operation
imap-codec copied to clipboard

Extend Python bindings CI workflow

Open HenningHolmDE opened this issue 1 year ago • 1 comments

This adds multi-platform/version CI build and test for the Python bindings to allow for corresponding wheel releases. The GitHub workflow is based on the CI template provided by maturin.

As multi-platform/version builds are now handled by CI, there is no longer an advantage in building the bindings for multiple Python versions locally when linting/building/testing through just bindings. Thus, building for all detected interpreter versions is removed for the recipe.

HenningHolmDE avatar Jul 26 '24 21:07 HenningHolmDE

Pull Request Test Coverage Report for Build 10132160296

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.981%

Totals Coverage Status
Change from base Build 10115120855: 0.0%
Covered Lines: 11180
Relevant Lines: 12024

💛 - Coveralls

coveralls avatar Jul 26 '24 21:07 coveralls

The diff looks bigger because we also have non-essential changes. Notably whitespace, .venv vs venv, and dist vs ../../target/wheels. Would you mind trying to reduce these changes? At least the non-essential whitespace changes? .venv vs venv could be easy as well. For the others, I would let you decide if you think it's worth it.

You are probably right that keeping the file as close to the template as possible makes sense. Thus, I now changed .venv/venv and dist/target back to how things are handled in the template. Now, the remaining changes should only be due to keeping the project in a subdirectory.

However, I'm not sure which whitespace changes you are referring to. I now changed the formatting of the header back to that of the template - were you referring to those?

HenningHolmDE avatar Jul 28 '24 13:07 HenningHolmDE

However, I'm not sure which whitespace changes you are referring to. I now changed the formatting of the header back to that of the template - were you referring to those?

Weird... I was referring to this:

image

This is the output of difftastic. But... I have difficulties finding out where this is coming from... I suspected that it's \n vs \r\n. But maybe it's a bug in difftastic. Sorry for the distraction.

duesee avatar Jul 28 '24 15:07 duesee