Make tuple and custom array declared as interface compatible

[devgony]

Description: Make tuple and custom array declared as interface compatible

BREAKING CHANGE:

Related issue (if exists): To resolve #216

[CLAassistant]

All committers have signed the CLA.

[devgony]

$ ./scripts/test.sh arityAndOrderCompatibility

2 unmatched errors out of 17 errors. Got 5 extra errors.
Wanted: [RefError { line: 19, column: 5, code: "TS2741" }, RefError { line: 22, column: 5, code: "TS2741" }]
Unwanted: [(19, "TS2322"), (22, "TS2322"), (30, "TS2322"), (34, "TS2322"), (35, "TS2322")]

I made it to remove (16, "TS2461"). Should i remove all the other 5 extra errors In this issue? 😢

[kdy1]

No, it's okay to split PRs. I'll review this PR once you undraft it.

[devgony]

I'm trying to solve nested_assignment error in advance of undraft but cannot get which part is wrong yet.

[kdy1]

Can you sign the CLA?

[kdy1]

I'm not sure if this code is working as there's no stat change. I'll run stat check locally..

[github-actions[bot]]

Thank you for the PR! Commit: ed10347a4900c6cb9c0f20094f2e230694d5b601

Files to check

These are files which is affected by the current PR, but not reflected. If there's no file below this message, please ignore this message.

You can run ./scripts/auto-unignore.sh from crates/stc_ts_file_analyzer for typescript files, and ./scripts/check.sh from crates/stc_ts_type_checker for *.stats.rust-debug files.

[sunrabbit123]

Is this PR resolved?

I'd like to see some test code added for those entering later.

It would be nice to know right away what you've done.

@devgony @kdy1

[kdy1]

@sunrabbit123 I think this PR is far from ready

[sunrabbit123]

Sorry about that. I thought the commit was old and being neglected.

[devgony]

@sunrabbit123 I haven't added any test cases so far. Yes.. this PR is still ongoing yet.

[devgony]

It seems that this PR is solved by another PR? Unlike before, ./scripts/test.sh arityAndOrderCompatibility passes all now. Or should I change or add more test cases ?

[kdy1]

Adding more tests would be awsome. Thank you!

[kdy1]

Adding more tests would be awesome. Thank you!

[changeset-bot[bot]]

⚠️ No Changeset found

Latest commit: ed10347a4900c6cb9c0f20094f2e230694d5b601

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR