herbe
herbe copied to clipboard
dudik
patch: OpenBSD
Description
Allows building on OpenBSD.
Original comment: OpenBSD uses a different path for X11 (and related) libs. And the default gcc is like 4.2 (from 2007!) -- egcc is a newer version.
Download
https://patch-diff.githubusercontent.com/raw/dudik/herbe/pull/4.diff
I'm not going to comment on the patch system you're essentially proposing, but regardless, your PR should not include the patch already applied in the makefile.
Ole Strøhm [email protected] wrote:
I'm not comment on the patch system you're essentially proposing, but regardless your PR should not include the patch already applied in the makefile.
Ah oops. Totally missed that. And I figured a patch would be a good idea since it keeps the code base untouched -- potentially preserving the author's ideals. Those who may wish to run herbe on an OpenBSD host can be directed to applying the patch.
Hello. Sorry for the incredible late response. I didn't answer because I knew I wanted to make some changes to the makefile, but I kept delaying it. Sorry. I finally made the changes and your patch is now outdated, but it's still a one-liner. I tested it myself on a virtual machine.
CFLAGS = -Wall -Wextra -pedantic -I/usr/X11R6/include -L/usr/X11R6/lib -lX11 -lXft -I/usr/X11R6/include/freetype2 -pthread
My question is, what do you think about about dylans way of patching? I'm also not quite sure if it's possible to somehow update this PR to the latest version or we have to close it and create a new one? I'm still kind of new to these things. Thank you.
Hey @dudik, no worries. Yeah, I quite like Dylan's approach to patching. Works for me.
And yes, this PR can be updated (even by you!) by pushing to https://github.com/icyphox/herbe at the fix-build-openbsd branch.