Navigation menu & themes

[dons20]

Hey @duckness, great work on the site, I just had a few suggestions (which perhaps I could do a PR for if you agree to them).

• Allow a light/dark mode toggle
  • The current background probably won't be everyone's favourite, and I personally don't like the particular tint is has. Nonetheless if it had a light mode it would be a lot more neutral and appealing.
• Have an easily accessible navigation to each item in a category.
  • By default, the Mask of Goblin sends everyone to Kasel's particular page, which only has a search to the top right and no other obvious navigation.
  • Same applies to the Artifacts. (Perhaps they could be populated on the same page since they aren't as detailed?)
• Possibly split hero pages into Attributes and Skill Details via an easily accessible tab to reduce scrolling.
  • This one isn't as necessary since there is a pretty useful navigation to the top left of the hero section.
• Highlight values that change when stats are modified
  • It would be easier to see values that are modified when leveling up or increasing transcendence levels by putting them bold, giving them a unique color and/or adding a background color.

Those are my main ideas to help improve this project. I'm willing to make PRs for most/all of these as long as you want them to be added.

Thanks

[duckness]

light/dark mode

Sure.

Navigation

I agree it needs some work. I can't think of a good way to do it while making it not look terrible though. I can't show all the images on one page as I'm trying to reduce bandwidth usage (Netlify is complaining about bandwidth).

Splitting attributes

Navigation wise, I'd prefer to keep them all on the same page instead of separating them. I do agree that scrolling might be an issue, which is why I have been hesitant to add extra stuff like the hero stories and inn lines even though they are already in the .json files

Highlight values that change when stats are modified

Currently, the strings for UW/UT/Artifacts are stored rather inefficiently, needing the full string per star (unlike skills). This stems from the fact that I'm just extracting the strings directly from the game files. It is difficult to automate extracting the change in values as Vespa sometimes leave typos in them (e.g., Frey 5* UW used to say 1050% atk), and sometimes the phrasing for different stars are also different. The fact that there are multiple languages also compound the issue. So changing it at the source is not a good idea.

[dons20]

Thanks for the quick reply, I only have one other suggestion to your feedback.

• For navigation you could simply have a vertical menu with text links to each hero/artifact. Images would be largely unnecessary for that purpose.

I'll consider forking and working on the features agreed to once I have some spare time.

[duckness]

For navigation you could simply have a vertical menu with text links to each hero/artifact. Images would be largely unnecessary for that purpose.

I'll think of something for the navigation.

I'll consider forking and working on the features agreed to once I have some spare time.

The offer is appreciated but not necessary, feel free to bug me again if I don't finish the navigation thing and the themes in a week from now.

[dons20]

Ok sounds good 👍 looking forward to it.

[duckness]

Navigation looks like this for now, I'll work on themes next.

[duckness]

ok, I'm too dumb/lazy to make custom theming work, I'll switch to a more neutral looking (IMO) dark theme.

[duckness]

2f087235e1d157722a250a36c80cf18aae0e7b58 pushed. Artifact menu will come later, think I want to manually map artifacts into standard/event/GC/WB categories into my scraping script.

[dons20]

Looks great so far! I like the menu arrangement, quite easy to find each hero..