iOS icon indicating copy to clipboard operation
iOS copied to clipboard
verified publisher icon duckduckgo

Add to Dock Onboarding feature flag

Open alessandroboron opened this issue 1 year ago • 0 comments

Task/Issue URL: https://app.asana.com/0/1206329551987282/1208577512136639/f

Description:

Add a feature flag used to show Add to Dock during the onboarding flow. Note that the feature will be available only for iPhone

Steps to test this PR:

Prerequisites:

Add return VariantIOS(name: "mu", weight: 1, isIncluded: When.always, features: [.newOnboardingIntro, .contextualDaxDialogs]) in DefaultVariantManager -> selectVariant() line 156.

Scenario 1 — When the End of Journey Dialog is presented from NTP and Add to Dock flag is enabled then log Add to Dock

  1. Complete onboarding intro.
  2. Wait for Contextual Dax dialogs to appear.
  3. Login as internal user.
  4. In the Debug menu -> New Onboarding -> enable Onboarding Add to Dock local setting.
  5. Progress with the contextual onboarding and use the fire button till seeing end of journey dialog.
  6. Ensure the Console log prints “Present Final Dialog with Add To Dock updates” (you need to enable subsystem in the metadata filter and set it to Onboarding)

Scenario 2 — When the End of Journey Dialog is presented from NTP and Add to Dock flag is disabled then log Add to Dock

  1. Complete onboarding intro.
  2. Wait for Contextual Dax dialogs to appear.
  3. In the Debug menu -> New Onboarding -> disable Onboarding Add to Dock local setting.
  4. Progress with the contextual onboarding and use the fire button till seeing end of journey dialog.
  5. Ensure the Console log prints “Present Final Dialog without Add To Dock updates” (you need to enable subsystem in the metadata filter and set it to Onboarding)

Scenario 3 — When the End of Journey Dialog is presented from in context and Add to Dock flag is enabled then log Add to Dock

  1. Complete onboarding intro.
  2. Wait for Contextual Dax dialogs to appear.
  3. Login as internal user.
  4. In the Debug menu -> New Onboarding -> enable Onboarding Add to Dock local setting.
  5. Progress with the contextual onboarding tille the fire dialog. Don’t use the fire dialog.
  6. Navigate to another website and wait for the contextual end of journey dialog is presented.
  7. Ensure the Console log prints “Present Contextual Final Dialog with Add To Dock updates” (you need to enable subsystem in the metadata filter and set it to Onboarding)

Scenario 4 — When the End of Journey Dialog is presented from in context and Add to Dock flag is disabled then log Add to Dock

  1. Complete onboarding intro.
  2. Wait for Contextual Dax dialogs to appear.
  3. Login as internal user.
  4. In the Debug menu -> New Onboarding -> enable Onboarding Add to Dock local setting.
  5. Progress with the contextual onboarding tille the fire dialog. Don’t use the fire dialog.
  6. Navigate to another website and wait for the contextual end of journey dialog is presented.
  7. Ensure the Console log prints “Present Contextual Final Dialog without Add To Dock updates” (you need to enable subsystem in the metadata filter and set it to Onboarding)

Definition of Done (Internal Only):

Copy Testing:

  • [ ] Use of correct apostrophes in new copy, ie ’ rather than '

Orientation Testing:

  • [ ] Portrait
  • [ ] Landscape

Device Testing:

  • [ ] iPhone SE (1st Gen)
  • [ ] iPhone 8
  • [ ] iPhone X
  • [ ] iPhone 14 Pro
  • [ ] iPad

OS Testing:

  • [ ] iOS 15
  • [ ] iOS 16
  • [ ] iOS 17

Theme Testing:

  • [ ] Light theme
  • [ ] Dark theme
Internal references:

Software Engineering Expectations Technical Design Template

alessandroboron avatar Oct 24 '24 09:10 alessandroboron