iOS icon indicating copy to clipboard operation
iOS copied to clipboard

Onboarding Intro - Remove Default Browser Screen

Open alessandroboron opened this issue 1 year ago • 1 comments

Task/Issue URL: https://app.asana.com/0/1206329551987282/1207736844779818/f

Description:

This PR addresses BG8/.

Steps to test this PR:

  1. Launch new Intro Flow
  2. Wait for Intro Dialog to appear.
  3. Tap “Let’s do it!” button.
  4. Wait for Browser comparison to appear.
  5. Ensure that the view has two CTAs as per Figma Variant
  6. Ensure that tapping on "Switch Default Browser” calls setDefaultBrowserAction in OnboardingIntroViewModel (there are unit tests for this if you’re wondering :D) and the view is dismissed.
  7. Ensure that tapping on “Skip” calls cancelSetDefaultBrowserAction in OnboardingIntroViewModel` and the view is dismissed.

Definition of Done (Internal Only):

Copy Testing:

  • [ ] Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • [ ] Portrait
  • [ ] Landscape

Device Testing:

  • [ ] iPhone SE (1st Gen)
  • [ ] iPhone 8
  • [ ] iPhone X
  • [ ] iPhone 14 Pro
  • [ ] iPad

OS Testing:

  • [ ] iOS 15
  • [ ] iOS 16
  • [ ] iOS 17

Theme Testing:

  • [ ] Light theme
  • [ ] Dark theme

Internal references:

Software Engineering Expectations Technical Design Template

alessandroboron avatar Jul 05 '24 07:07 alessandroboron

:no_entry_sign: The Asana task linked in the PR description is not added to iOS App Board project.

  1. Verify that the correct task is linked in the PR.
    • :warning: Please use the actual implementation task, rather than the Code Review subtask.
  2. Verify that the task is added to iOS App Board project.
  3. When ready, remove the bot: not in app board label to retrigger the check.

github-actions[bot] avatar Jul 05 '24 07:07 github-actions[bot]