implement contextual dialogs
Task/Issue URL: https://app.asana.com/0/1204186595873227/1207736729379245/f
Description: Implements the Dialog we will use in the contextual onboarding cc. @alessandroboron
Steps to test this PR:
- Use the Preview of the following files: ContextualDaxDialog, ContextualOnboardingList, ContextualOnboardingDialogs
- the latest represent the top level ones that will be displayed
Definition of Done (Internal Only):
- [ ] Does this PR satisfy our Definition of Done?
Copy Testing:
- [ ] Use of correct apostrophes in new copy, ie
’rather than'
Orientation Testing:
- [ ] Portrait
- [ ] Landscape
Device Testing:
- [ ] iPhone SE (1st Gen)
- [ ] iPhone 8
- [ ] iPhone X
- [ ] iPhone 14 Pro
- [ ] iPad
OS Testing:
- [ ] iOS 15
- [ ] iOS 16
- [ ] iOS 17
Theme Testing:
- [ ] Light theme
- [ ] Dark theme
Internal references:
:no_entry_sign: The Asana task linked in the PR description is not added to iOS App Board project.
- Verify that the correct task is linked in the PR.
- :warning: Please use the actual implementation task, rather than the Code Review subtask.
- Verify that the task is added to iOS App Board project.
- When ready, remove the
bot: not in app boardlabel to retrigger the check.
| Warnings | |
|---|---|
| :warning: | PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible. |
Generated by :no_entry_sign: dangerJS against d2ca78422e89a166efe7c4f28675c0326e23b10d
As per MM conversation, there’s an issue with the typing animation. The box grows as the typing goes. We can look at adapting AnimatableTypingText with AttributedString. Having said that I think we should finish the functionality first and look at animations later.
As per MM conversation, there’s an issue with the typing animation. The box grows as the typing goes. We can look at adapting AnimatableTypingText with AttributedString. Having said that I think we should finish the functionality first and look at animations later.
I should have fixed it! but have not used the existing stuff when can always see later if we want to combine them.
Good job adapting AnimatableTypingText, it works very well! 👏
The views that show a list of suggestions need a VM, but we can add it in another PR when we have the provider ready.
On another note, there’s a conflict with the main feature branch DaxDialogIntroView. I removed this file DaxDialogIntroView.swift, so it shouldn’t be too bad to resolve it.
LGTM, very nice. Agree with @alessandroboron we need a view model though, but can follow up with that.
Yes, I agree too there will be a need for a view model but it didn’t make sense to add it now when it does not do anything yet