iOS icon indicating copy to clipboard operation
iOS copied to clipboard

Onboarding Intro - Pixels

Open alessandroboron opened this issue 1 year ago • 1 comments

Task/Issue URL: https://app.asana.com/0/1206329551987282/1207723831937959 CC: @SabrinaTardio

Description: Add Pixels to Onboarding Intro flow. Pixel Definitions #2, #3, #4.

Pixels #2 #3 are unique as per comment.

Steps to test this PR:

SCENARIO 1 - New Intro Flow

  1. Launch the New Onboarding Intro Flow
  2. Wait for the Dax Dialog “Ready for a better internet?” appears
  3. Ensure that m.preonboarding.intro.shown Pixel #2 is fired.
  4. Tap “Let’s do it”
  5. Wait for the Browser Chart to appear
  6. Ensure that m.preonboarding.comparison.chart.shown Pixel #3 is fired.
  7. Tap “Choose Your Browser” 8 Ensure that m.preonboarding.choose.browser.pressed Pixel #4 is fired.
  8. Repeat the steps and ensure that m.preonboarding.intro.shown and m.preonboarding.comparison.chart.shown are not fired again

SCENARIO 2 - Old Onboarding Flow

  1. Enable Old onboarding flow (Edit Scheme -> Arguments -> Environment Variables -> Onboarding -> enable)
  2. Launch App
  3. Ensure that the m.preonboarding.intro.shown Pixes #2 is fired.
  4. Repeat the steps and ensure that m.preonboarding.intro.shown is not fired again.

Definition of Done (Internal Only):

Copy Testing:

  • [ ] Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • [ ] Portrait
  • [ ] Landscape

Device Testing:

  • [ ] iPhone SE (1st Gen)
  • [ ] iPhone 8
  • [ ] iPhone X
  • [ ] iPhone 14 Pro
  • [ ] iPad

OS Testing:

  • [ ] iOS 15
  • [ ] iOS 16
  • [ ] iOS 17

Theme Testing:

  • [ ] Light theme
  • [ ] Dark theme

Internal references:

Software Engineering Expectations Technical Design Template

alessandroboron avatar Jul 04 '24 04:07 alessandroboron

:no_entry_sign: The Asana task linked in the PR description is not added to iOS App Board project.

  1. Verify that the correct task is linked in the PR.
    • :warning: Please use the actual implementation task, rather than the Code Review subtask.
  2. Verify that the task is added to iOS App Board project.
  3. When ready, remove the bot: not in app board label to retrigger the check.

github-actions[bot] avatar Jul 04 '24 04:07 github-actions[bot]

This LGTM but I'll let @SabrinaTardio approve it since she had feedback before.

brindy avatar Jul 12 '24 11:07 brindy