iOS icon indicating copy to clipboard operation
iOS copied to clipboard

Add alpha_adhoc lane

Open ayoy opened this issue 1 year ago • 1 comments

Task/Issue URL: Tech Design URL: CC:

Description:

Steps to test this PR: 1. 2.

Copy Testing:

  • [ ] Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • [ ] Portrait
  • [ ] Landscape

Device Testing:

  • [ ] iPhone SE (1st Gen)
  • [ ] iPhone 8
  • [ ] iPhone X
  • [ ] iPhone 14 Pro
  • [ ] iPad

OS Testing:

  • [ ] iOS 14
  • [ ] iOS 15
  • [ ] iOS 16

Theme Testing:

  • [ ] Light theme
  • [ ] Dark theme

Internal references:

Software Engineering Expectations Technical Design Template

ayoy avatar Feb 21 '24 17:02 ayoy

@ayoy Finally had a moment to check this. I think we can merge as is and parametrize later. There are few moving/changing parts. WDYT?

What would be the expected scenario for parametrization? Having a single ad-hoc build action and picking PROD/ALPHA alongside the branch? 🤔

afterxleep avatar Mar 29 '24 17:03 afterxleep

@afterxleep thanks! Regarding parametrization I only meant reworking fastlane code to avoid duplication, but I agree that it shouldn't block us from merging this. GHA workflow can be added at a later time 👍🏻

Please merge it at your convenience then :) thanks for moving this forward 🙏🏻

cc @jaceklyp

ayoy avatar Apr 02 '24 05:04 ayoy

This PR has been inactive for more than 7 days and will be automatically closed 7 days from now.

github-actions[bot] avatar Apr 13 '24 00:04 github-actions[bot]