firefox-zeroclickinfo icon indicating copy to clipboard operation
firefox-zeroclickinfo copied to clipboard

Don't require restart to effect "Answers on Google/Bing" setting

Open mcandre opened this issue 10 years ago • 6 comments

Thank you for providing a setting for "Answers on Google/Bing (on top of links)". Would it be possible to make this setting take effect on change, so that the browser doesn't have to be restarted? For example, AdBlock Plus can do this.

mcandre avatar Aug 13 '14 15:08 mcandre

Hey @mcandre,

The setting should not require a restart. The only thing that should be required is just a reload of given webpage (in this case Google or Bing).

Are you experiencing behavior that contradicts my previous statement?

mrshu avatar Aug 13 '14 16:08 mrshu

That's good to hear.

Yes, I am experiencing different behaviour. Refreshing the Google results page seems to have no effect, nor does force-refreshing with Control+Shift+R.

I'm using Firefox 31, with:

  • AdBlock Plus 2.6.4
  • DuckDuckGo Plus 0.4.2
  • LastPass 3.1.1
  • Ubuntu Firefox Modifications 2.9
  • Ubuntu Online Accounts 0.5
  • Unity Desktop Integration 3.0.2
  • Unity Websites integration 2013.09.20 beta

On Ubuntu 14.04 Trusty Tahr.

As a workaround, I was able to finally remove DuckDuckGo search results from my Google results pages by unchecking the "Answers on Google/Bing (on top of links)" setting in the DuckDuckGo extension and relaunching Firefox.

mcandre avatar Aug 13 '14 18:08 mcandre

@mcandre thanks for the report.

I'm sorry but I'm still unable to reproduce what you describe. How do you switch the Answers on Google/Bing setting? In the popup? In the about:addons settings page?

What do you see when you toggle the options, especially when you turn it off? You should notice that the CSS got destroyed and thus the DDG search result should be visually broken. Can you see that?

Thanks again for your cooperation.

mrshu avatar Aug 15 '14 02:08 mrshu

Yes, I switch the setting in the DDG preferences popup, from the about:addons page.

When I toggle the option to off, the CSS does not visibly change for my https://encrypted.google.com/?q=... pages.

On Thu, Aug 14, 2014 at 9:44 PM, Marek Šuppa [email protected] wrote:

@mcandre https://github.com/mcandre thanks for the report.

I'm sorry but I'm still unable to reproduce what you describe. How do you switch the Answers on Google/Bing setting? In the popup? In the about:addons settings page?

What do you see when you toggle the options, especially when you turn it off? You should notice that the CSS got destroyed and thus the DDG search result should be visually broken. Can you see that?

Thanks again for your cooperation.

— Reply to this email directly or view it on GitHub https://github.com/duckduckgo/firefox-zeroclickinfo/issues/27#issuecomment-52269176 .

Cheers,

Andrew Pennebaker www.yellosoft.us

mcandre avatar Aug 15 '14 13:08 mcandre

@mcandre sorry for the holdup. I've tried lots of scenarios but it seems that I am just impossible to reproduce your issue.

In the meantime many things have changed. Can you please try the latest build and see if the issue still persists?

Thanks.

mrshu avatar Aug 25 '14 14:08 mrshu

@mcandre any chance you've tried the latest build? I'd like to make sure this one feature is not broken for anybody.

Thanks

mrshu avatar Sep 09 '14 22:09 mrshu