duckduckgo-privacy-extension
duckduckgo-privacy-extension copied to clipboard
Remove parameterName and parameterValue from ad-attribution feature to simplify code
Reviewer: @englehardt
Description:
Marking draft as CI should fail if working correcly; testCases still need amending.
This is to simplify the parsing logic as we already verify an ad click based on the adDomainParameterName parameter name in the link click.
https://app.asana.com/0/0/1202808108652811/f
Corresponding config change should probably land first so we can just run bundle-config instead of hand hacking it: https://github.com/duckduckgo/privacy-configuration/pull/345
Steps to test this PR:
Automated tests:
- [ ] Unit tests
- [ ] Integration tests
Reviewer Checklist:
- [ ] Ensure the PR solves the problem
- [ ] Review every line of code
- [ ] Ensure the PR does no harm by testing the changes thoroughly
- [ ] Get help if you're uncomfortable with any of the above!
- [ ] Determine if there are any quick wins that improve the implementation
PR Author Checklist:
- [ ] Get advice or leverage existing code
- [ ] Agree on technical approach with reviewer (if the changes are nuanced)
- [ ] Ensure that there is a testing strategy (and documented non-automated tests)
- [ ] Ensure there is a documented monitoring strategy (if necessary)
- [ ] Consider systems implications