content-scope-scripts icon indicating copy to clipboard operation
content-scope-scripts copied to clipboard

Release Notes add “loadingError” state

Open vkraucunas opened this issue 7 months ago • 4 comments

Asana Task/Github Issue: https://app.asana.com/1/137249556945/inbox/1208403785647358/item/1210113027736521/story/1210167629021499

Description

Windows will be retrieving release notes data from a CDN instead of bundling with the build like macOS did, so we need to handle for when the request to the CDN fails, and has failed the device’s retries.

Testing Steps

  • Loading Error state

    • Should resolve to a new error view with “Error loading update summary” status text and a “reload summary” retry button that fires a retryFetchReleaseNotes notification message on click (console logs demo this)
  • UI Updates on MacOS

    • Should show Mac-style button
    • “Thanks for choosing DuckDuckGo!” at top of view

Checklist

Please tick all that apply:

  • [ ] I have tested this change locally
  • [ ] I have tested this change locally in all supported browsers
  • [ ] This change will be visible to users
  • [ ] I have added automated tests that cover this change
  • [ ] I have ensured the change is gated by config
  • [ ] This change was covered by a ship review
  • [ ] This change was covered by a tech design
  • [ ] Any dependent config has been merged

vkraucunas avatar May 08 '25 00:05 vkraucunas

Deploy Preview for content-scope-scripts ready!

Name Link
Latest commit b8174a37bbc012a00239b0f4baf83ff0b2582792
Latest deploy log https://app.netlify.com/projects/content-scope-scripts/deploys/68373b74ca05aa0009298bdb
Deploy Preview https://deploy-preview-1672--content-scope-scripts.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify[bot] avatar May 08 '25 00:05 netlify[bot]

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

github-actions[bot] avatar May 08 '25 00:05 github-actions[bot]

[Beta] Generated file diff

Time updated: Wed, 28 May 2025 16:36:44 GMT

Integration
    - integration/pages/example/dist/index.css
  • integration/pages/history/dist/index.css
  • integration/pages/new-tab/dist/index.css
  • integration/pages/new-tab/dist/index.js
  • integration/pages/release-notes/dist/index.css
  • integration/pages/release-notes/dist/index.js
  • integration/pages/release-notes/dist/inline.js
  • integration/pages/release-notes/index.html
  • integration/pages/release-notes/locales/de/release-notes.json
  • integration/pages/release-notes/locales/en/release-notes.json
  • integration/pages/release-notes/locales/es/release-notes.json
  • integration/pages/release-notes/locales/fr/release-notes.json
  • integration/pages/release-notes/locales/it/release-notes.json
  • integration/pages/release-notes/locales/nl/release-notes.json
  • integration/pages/release-notes/locales/pl/release-notes.json
  • integration/pages/release-notes/locales/pt/release-notes.json
  • integration/pages/release-notes/locales/ru/release-notes.json
  • integration/pages/special-error/dist/index.css
  • integration/pages/special-error/dist/index.js

File has changed

Windows
    - windows/pages/history/dist/index.css
  • windows/pages/new-tab/dist/index.css
  • windows/pages/new-tab/dist/index.js
  • windows/pages/special-error/dist/index.css
  • windows/pages/special-error/dist/index.js
  • windows/pages/special-error/index.html

File has changed

Apple
    - dist/pages/history/dist/index.css
  • dist/pages/new-tab/dist/index.css
  • dist/pages/new-tab/dist/index.js
  • dist/pages/release-notes/dist/index.css
  • dist/pages/release-notes/dist/index.js
  • dist/pages/release-notes/dist/inline.js
  • dist/pages/release-notes/index.html
  • dist/pages/release-notes/locales/de/release-notes.json
  • dist/pages/release-notes/locales/en/release-notes.json
  • dist/pages/release-notes/locales/es/release-notes.json
  • dist/pages/release-notes/locales/fr/release-notes.json
  • dist/pages/release-notes/locales/it/release-notes.json
  • dist/pages/release-notes/locales/nl/release-notes.json
  • dist/pages/release-notes/locales/pl/release-notes.json
  • dist/pages/release-notes/locales/pt/release-notes.json
  • dist/pages/release-notes/locales/ru/release-notes.json
  • dist/pages/special-error/dist/index.css
  • dist/pages/special-error/dist/index.js
  • dist/pages/special-error/index.html

File has changed

New Files
    - windows/pages/release-notes/dist/Check-Color-24-Y2U7ZXXE.svg
  • windows/pages/release-notes/dist/Exclamation-Color-24-AAA3M64P.svg
  • windows/pages/release-notes/dist/Exclamation-High-Color-24-6LOXQFBN.svg
  • windows/pages/release-notes/dist/Logo-Horizontal-A4FFOYBB.svg
  • windows/pages/release-notes/dist/Logo-Horizontal-Dark-BQCDSFDZ.svg
  • windows/pages/release-notes/dist/Privacy-Pro-Color-16-42TBSCRM.svg
  • windows/pages/release-notes/dist/Spinner-16-Dark-CEPTUYIF.svg
  • windows/pages/release-notes/dist/Spinner-16-PX3I3MW3.svg
  • windows/pages/release-notes/dist/index.css
  • windows/pages/release-notes/dist/index.js
  • windows/pages/release-notes/dist/inline.js
  • windows/pages/release-notes/index.html
  • windows/pages/release-notes/locales/de/release-notes.json
  • windows/pages/release-notes/locales/en/release-notes.json
  • windows/pages/release-notes/locales/es/release-notes.json
  • windows/pages/release-notes/locales/fr/release-notes.json
  • windows/pages/release-notes/locales/it/release-notes.json
  • windows/pages/release-notes/locales/nl/release-notes.json
  • windows/pages/release-notes/locales/pl/release-notes.json
  • windows/pages/release-notes/locales/pt/release-notes.json
  • windows/pages/release-notes/locales/ru/release-notes.json
  • windows/pages/release-notes/robots.txt

❌ File only exists in new changeset

github-actions[bot] avatar May 08 '25 00:05 github-actions[bot]

@vkraucunas can you please enable release-notes for the windows build, via special-pages/index.mjs Currently release-notes are only available for mac

deanmalone avatar May 09 '25 04:05 deanmalone