community-platform
community-platform copied to clipboard
Maps UI accessibility improvements
DuckDuckGo maps has a few accessibility issues. Additionally it inherits accessibility issues in MapKit (which I have reported in the Apple developer forum).
I believe the following issues are specific to DuckDuckGo maps (not inherited by the MapKit JS framework):
Back button
![](https://user-images.githubusercontent.com/26493779/109389667-9bc75600-790d-11eb-9f11-ddfdea76cae4.png)
- Is missing
role="button"
(preferably it should be<button>
) - Is missing an accessible name e.g.
aria-label="Back"
Clear search button
![](https://user-images.githubusercontent.com/26493779/109389020-cebc1a80-790a-11eb-8913-d0ac0264d5f5.png)
- The accessible name is "X". This should be descriptive, e.g.
aria-label="Clear search"
- Although fousable, it is not reachable using a keyboard
Search button
![](https://user-images.githubusercontent.com/26493779/109389027-d2e83800-790a-11eb-9f75-c7190c4d4fb1.png)
- The accessible name is "S". This should be descriptive, e.g.
aria-label="Search"
Close sidebar button
![](https://user-images.githubusercontent.com/26493779/109389049-f1e6ca00-790a-11eb-8723-9b0e52ef0c42.png)
- The accessible name is "<". This should be descriptive, e.g.
aria-label="(Close|Hide) details"
Open sidebar button
![](https://user-images.githubusercontent.com/26493779/109389057-f6ab7e00-790a-11eb-9b71-596b70758758.png)
- The accessible name is ">". This should be descriptive, e.g.
aria-label="(Open|Show) details"
Locate Me button
![](https://user-images.githubusercontent.com/26493779/109389035-ded3fa00-790a-11eb-8b43-a13bed12fb7e.png)
- Is not keyboard focusable
- Is missing semantics. It should be
<button>
(or<a (tabindex="0"|href="#") role="button">
) - Is missing an accessible name. This should be descriptive, e.g.
aria-label="Locate me"
Close Locate Me button
![](https://user-images.githubusercontent.com/26493779/109389066-ff9c4f80-790a-11eb-9c60-1e70a39a38ee.png)
- Is not keyboard focusable
- Has no semantics. It should be
<button>
(or<a (tabindex="0"|href="#") role="button">
) - Is missing an accessible name. This should be descriptive, e.g.
aria-label="Close"
Activate Locate Me button
![](https://user-images.githubusercontent.com/26493779/109390899-93264e00-7914-11eb-848c-dbed94470ade.png)
- Is not keyboard focusable
- It should be
<button>
(or<a (tabindex="0"|href="#") role="button">
)
(these things apply to the "button" next to it aswell)
I'm just scratching the surface though, other things to consider:
- Focus delegation (For example, you'd probably want to send focus to the "dialog" after clicking the Locate Me button. As well as send focus back to the Locate Me button once the dialog has been closed. Per the WAI-ARIA Authoring Practices recommended Keyboard Interactions for buttons)
- CSS outlines. It seems outlines are disabled, consider enabling outlines at least for keyboard users (see
:focus-visible
).