Android icon indicating copy to clipboard operation
Android copied to clipboard

Quick win: Animate omnibar with keyboard

Open 0nko opened this issue 3 months ago • 2 comments

Task/Issue URL: https://app.asana.com/1/137249556945/project/715106103902962/task/1210318103652397

Description

This PR fixes an issue when the bottom omnibar jump when the keyboard is shown/hidden.

Steps to test this PR

Omnibar animation

  • [ ] Set the omnibar to the bottom position in the Appearance settings
  • [ ] Go to the browser and select the address bar to show the keyboard
  • [ ] Verify the omnibar moves along the keyboard as it moves up
  • [ ] Tap on the back arrow in the omnibar to remove the focus
  • [ ] Verify the omnibar moves along the keyboard as it moves down

Omnibar hiding

  • [ ] Open a website with an element fixed at the bottom (i.e. theguardian.com)
  • [ ] Notice the bottom-anchored element is fully visible
  • [ ] Swipe the website up to hide the omnibar
  • [ ] Notice that as the omnibar hides, the web content expands
  • [ ] Swipe the website down to expand the omnibar
  • [ ] Notice the web content moves up and is fully visible

UI changes

Screen_recording_20250917_213412.webm

0nko avatar Sep 03 '25 19:09 0nko

@LukasPaczos @0nko do you need any help to get this one done? I’d love to see this merged, looks great.

malmstein avatar Nov 05 '25 13:11 malmstein

Thanks @malmstein! @LukasPaczos found an issue with how the toolbar is animated when the keyboard disappears. I worked on this while I was in between TPs but then didn't get a chance to come back to it once I started on new project. If you have a some time to take a look at it that'd be great.

0nko avatar Nov 05 '25 21:11 0nko