Android icon indicating copy to clipboard operation
Android copied to clipboard
verified publisher icon duckduckgo

Address the tasks in the Meta section

Open anikiki opened this issue 1 year ago • 1 comments

Task/Issue URL: https://app.asana.com/0/72649045549333/1208287265878043/f

Description

Added feature flag for switch to tab. Removed unneeded quick insert icons. Formatted urls in autosuggest. Added dividers between autosuggest sections. Updated color on switch to tab icon.

Steps to test this PR

Feature 1

  • [x] Install from this branch.
  • [x] Open a few tabs.
  • [x] Search for something that matches the open tabs. Notice there's a divides between the top hits and search items. Notice there's a divider between the search items and the bottom section.
  • [x] Notice the quick insert icon is available only for search suggestions.
  • [x] Notice all URLs in suggestions don't have http://www., htps://www., www. as prefix and they don't have a trailing /.
  • [x] Notice that if you turn off the autocompleteTabs from Feature Flag Inventory you don't see the Switch to tab suggestions.

UI changes

Divider dark node Divider light mode
divider_light_mode divider_dark_mode
No top divider Bottom divider
no_top_divider bottom_divider

anikiki avatar Oct 08 '24 11:10 anikiki

  • #5168 Graphite
  • #5165 Graphite
  • #5123 Graphite
  • #5105 Graphite 👈
  • #5065 Graphite
  • #5064 Graphite
  • #5063 Graphite
  • #5042 Graphite
  • #5019 Graphite
  • #5018 Graphite
  • develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @anikiki and the rest of your teammates on Graphite Graphite

anikiki avatar Oct 08 '24 11:10 anikiki