Android icon indicating copy to clipboard operation
Android copied to clipboard
verified publisher icon duckduckgo

Handle clicks on "Switch to tab"

Open anikiki opened this issue 1 year ago • 3 comments

Task/Issue URL: https://app.asana.com/0/1200581511062568/1208264037618742/f

Description

Handled tab switching.

Steps to test this PR

Feature 1

  • [x] Install from this branch.
  • [x] Open a few tabs.
  • [x] Search for something and tap on one of the suggestions to "Switch to Tab" (the text is not there yet).
  • [x] Notice that tab is now selected. If there are multiple identical tabs (pointing to the same URL) the first one is selected.

NO UI changes

anikiki avatar Sep 19 '24 17:09 anikiki

  • #5168 Graphite
  • #5165 Graphite
  • #5123 Graphite
  • #5105 Graphite
  • #5065 Graphite
  • #5064 Graphite
  • #5063 Graphite
  • #5042 Graphite 👈
  • #5019 Graphite
  • #5018 Graphite
  • develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @anikiki and the rest of your teammates on Graphite Graphite

anikiki avatar Sep 19 '24 17:09 anikiki

Looks good and works as expected. I've noticed that if an open tab is also in history, then we won't switch to a new tab ut navigate instead, but I'm assuming that's expected and will be addressed later in the stack

CrisBarreiro avatar Sep 26 '24 15:09 CrisBarreiro

@anikiki I just realized that when clicking "Switch to tab" from the widget, we're opening a new tab instead. Can you please have a look?

Good catch @CrisBarreiro! Thanks :+1: I added a commit that fixes it.

anikiki avatar Oct 10 '24 15:10 anikiki