Android icon indicating copy to clipboard operation
Android copied to clipboard

Omnibar position: Settings and store

Open 0nko opened this issue 1 year ago • 1 comments

Task/Issue URL: https://app.asana.com/0/1207418217763355/1206100017017597/f Figma link: https://www.figma.com/design/Z4TFKpzzc02naMpqYO9ehv/Bottom-URL-bar-(Android)?node-id=1-2&t=oeftk6SHYD0A2iwr-1

Description

This PR adds a new Settings option to change the position of the browser address bar. The selected value is saved in the user preferences.

Steps to test this PR

  • [ ] Go to Settings
  • [ ] Tap on Appearance
  • [ ] Notice a new Address Bar option
  • [ ] Tap on it and notice a dialog shows up
  • [ ] Change the section and Save
  • [ ] Notice the new selection is reflected in the setting description
  • [ ] Leave the Settings
  • [ ] Navigate back to Appearance settings
  • [ ] Notice the selection was preserved

UI changes

https://github.com/user-attachments/assets/f2fb8635-6e96-4439-a130-dea91e7b11de

0nko avatar Aug 09 '24 23:08 0nko

[!WARNING] This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite. Learn more

  • #4939 Graphite
  • #4930 Graphite
  • #4886 Graphite 👈
  • #4885 Graphite: 4 other dependent PRs (#4940 Graphite, #4941 Graphite, #4974 Graphite and 1 other)
  • develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @0nko and the rest of your teammates on Graphite Graphite

0nko avatar Aug 09 '24 23:08 0nko