Android
Android copied to clipboard
duckduckgo
Add support for Duck Player
Task/Issue URL: https://app.asana.com/0/1205008441501016/1207588004626729/f
Description
- Add Duck Player support
- Navigate from Duck Player back to YouTube
- Add Duck Player settings
- Open YT URLs in Duck Player if setting is Enabled(Always)
- Add Duck Player Prime Modal
- Add Contingency settings
Steps to test this PR
https://app.asana.com/0/0/1207704461779423/f Note: There have been changes to the JS integration, so you might need to test these changes on the top of the stack
User preferences "Always" open Duck Player
- [x] Open Settings -> Duck Player -> Set to always
- [x] Type a YT URL on the omnibar
- [x] Check Duck Player is loaded
- [x] Navigate back and check you're going to the previous page your were visiting
User preferences "Always ask" trigger overlay
- [x] Open Settings -> Duck Player -> Set to always ask
- [x] Type a YT URL on the omnibar
- [x] Check overlay is loaded in YT
- [x] Check that watch here removes the overlay, and watch in Duck player navigates to Duck Player
User preferences "Never" stays in YT
- [x] Open Settings -> Duck Player -> Set to never
- [x] Type a YT URL on the omnibar
- [x] Check video is loaded normally
Feature 1
- [x] Open Duck Player
- [x] Click Info button
- [x] Check prime modal is correctly shown in both landscape and portrait
Feature 1
- [x] See https://app.asana.com/0/1205008441501016/1207714050281768/f (How to test, at the bottom of the description)
Feature 1
- [x] Open a video in Duck Player with settings to Always Ask
- [x] Click the watch in YouTube Button
- [x] Check overlay isn't shown
UI changes
See https://app.asana.com/app/asana/-/get_asset?asset_id=1207785858877769
UI changes
This stack of pull requests is managed by Graphite. Learn more about stacking.
Join @CrisBarreiro and the rest of your teammates on 
Graphite
