Android icon indicating copy to clipboard operation
Android copied to clipboard

Sync: Add a Favourite triggers Sync

Open malmstein opened this issue 2 years ago • 2 comments

Task/Issue URL: https://app.asana.com/0/488551667048375/1206579231041835/f

Description

This PR fixes the issue that adding a favourite doesn’t immediately trigger Sync The modified date wasn’t correct, so we fixed that.

Steps to test this PR

From develop

  • [ ] Create a sync account
  • [ ] add a bookmark
  • [ ] don't interact with bottom sheet
  • [ ] Then go to bookmarks screen.
  • [ ] Add bookmark as favorite:
  • [ ] overlflow menu → add as favorite
  • [ ] or, overflow menu → edit → add as favorite ❌ neither operation triggers sync (sync is triggered, but bookmarks says no changed)

From this branch

  • [ ] Create a sync account
  • [ ] add a bookmark
  • [ ] don't interact with bottom sheet
  • [ ] Then go to bookmarks screen.
  • [ ] Add bookmark as favorite:
  • [ ] overlflow menu → add as favorite
  • [ ] or, overflow menu → edit → add as favorite
  • [ ] Sync is triggered, favourites folder and entity have changed

malmstein avatar Feb 13 '24 15:02 malmstein

  • #4179 Graphite 👈
  • develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @malmstein and the rest of your teammates on Graphite Graphite

malmstein avatar Feb 13 '24 15:02 malmstein

@cmonfortep I jumped the gun too quickly, this doesn’t work when adding the favourite from the dialog

malmstein avatar Feb 13 '24 16:02 malmstein