Android icon indicating copy to clipboard operation
Android copied to clipboard
verified publisher icon duckduckgo

Override viewport when desktop mode enabled

Open cmonfortep opened this issue 3 years ago • 3 comments

Task/Issue URL: https://app.asana.com/0/414730916066338/1172939626954562/f

Description

To improve our desktop mode on mobile, we are overriding viewport width when desktop mode is enabled

Steps to test this PR

Desktop site

  • [ ] go to stackoverflow
  • [ ] change to desktop site (overflow menu)
  • [ ] ensure site loads desktop site instead of mobile site

(trying the same with the current production app will load mobile site always)

UI changes

Before After
old-desktop-mode new-desktop-mode

cmonfortep avatar Jul 06 '22 14:07 cmonfortep

@cmonfortep is this ready for review?

catehstn avatar Aug 02 '22 10:08 catehstn

@catehstn yes, it is. I will try to find a reviewer, but low priority here.

cmonfortep avatar Aug 02 '22 13:08 cmonfortep

@cmonfortep do you need help with this?

malmstein avatar Sep 09 '22 07:09 malmstein

Closing outdated PR.

malmstein avatar Jun 23 '23 10:06 malmstein