Allow Mic and Camera Permissions in websites
Task/Issue URL: https://app.asana.com/0/0/1202399817058484/f
Description
Allow users to enable mic or camera permissions if website requests it
Steps to test this PR
Microphone dialog
- Install from this branch
- Go to
www.mictest.cc - Tap on "Test my cam" button
- [ ] Check rationale dialog appears ask you only for mic permissions and allow
- [ ] If system permission not granted before -> check system permission dialog appears
- Allow permission
- [ ] Check microphone is working for site
Camera dialog
- Install from this branch
- Go to
www.webcamtest.cc - Tap on "Test my mic" button
- [ ] Check rationale dialog appears ask you only for camera permissions and allow
- [ ] If system permission not granted before -> check system permission dialog appears
- Allow permission
- [ ] Check camera is working for site
Mic & Camera dialog
- Install from this branch
- Go to
webcamera.io - [ ] Check rationale dialog appears ask you for mic and camera permissions and allow
- [ ] If system permissions not granted before -> check system permission dialogs appears
- Allow permissions
- [ ] Check microphone and camera is working for site
Left some comments on the PR.
I was not able to test the PR because it automatically crashes on my device 🤷, could you double check if it works on your side?
Yes, it works fine to me 🤔 I replied to your comments and commit some fixes 👍
Changed SitePermissionsDialogActivityLauncher scope to be single instance in Fragment instead Activity scope. Thanks for the suggestion @cmonfortep 💯
@nalcalag there's a conflict produced by https://github.com/duckduckgo/Android/pull/2322
