pg_duckdb icon indicating copy to clipboard operation
pg_duckdb copied to clipboard

Support postgresql 14

Open Z-Xiao-M opened this issue 1 year ago • 3 comments

Z-Xiao-M avatar Oct 09 '24 16:10 Z-Xiao-M

@JelteF Excuse me There is an error that postgresql14 does not support the following SQL image Would like to ask, how to modify here

Z-Xiao-M avatar Oct 09 '24 16:10 Z-Xiao-M

I think the easiest is to change those specific tests to a python test and skip them for PG14. i.e. create a new file test/pycheck/temporary_table_test.py.

To be clear we won't have time to review this in detail or merge this before the 0.1.0 release. But given the small number of necessary changes, I think this can definitely be targeted for 0.2.0.

Thank you for your contribution

JelteF avatar Oct 09 '24 17:10 JelteF

I think the easiest is to change those specific tests to a python test and skip them for PG14. i.e. create a new file test/pycheck/temporary_table_test.py.

To be clear we won't have time to review this in detail or merge this before the 0.1.0 release. But given the small number of necessary changes, I think this can definitely be targeted for 0.2.0.

Thank you for your contribution

Understood. Thank you for your guidance

Z-Xiao-M avatar Oct 10 '24 09:10 Z-Xiao-M

Did you close this on purpose? I was planning to merge this soon-ish.

JelteF avatar Nov 06 '24 14:11 JelteF

Did you close this on purpose? I was planning to merge this soon-ish.

No, no, I see a lot of changes, I plan to reorganize and resubmit.

Z-Xiao-M avatar Nov 06 '24 14:11 Z-Xiao-M

Ah alright. Sounds good, yeah we're refactoring a bunch of things to make the C vs C++ division clearer.

JelteF avatar Nov 06 '24 14:11 JelteF

Ah alright. Sounds good, yeah we're refactoring a bunch of things to make the C vs C++ division clearer.

This is good, I also want to try to do a little better, let you misunderstanding, sorry.

Z-Xiao-M avatar Nov 06 '24 14:11 Z-Xiao-M