`make bundle-library` doesn't work on windows
What happens?
The bundle-library target for make assumes the system uses the .a extension, and the location of these archives.
Both of these are different on windows, the extension should be .lib, and the files are all inside a Release directory.
eg: src/Release/duckdb_static.lib, third_party/*/Release/duckdb_*.lib and extension/*/Release/*_extension.lib
To Reproduce
Run make bundle-library
OS:
windows amd64 (normal github CI)
DuckDB Version:
1.0.0
DuckDB Client:
none
Full Name:
Jaap
Affiliation:
None
What is the latest build you tested with? If possible, we recommend testing with the latest nightly build.
I have tested with a source build
Did you include all relevant data sets for reproducing the issue?
Not applicable - the reproduction does not require a data set
Did you include all code required to reproduce the issue?
- [X] Yes, I have
Did you include all relevant configuration (e.g., CPU architecture, Python version, Linux distribution) to reproduce the issue?
- [X] Yes, I have
Bundle-library was introduced here: https://github.com/duckdb/duckdb/pull/10507
Just for some context
Even more issues: when using mingw on windows (mingw makefiles cmake generator) the archives are .lib.a and are located under the normal gcc paths (eg. extension/*/lib*_extension.lib.a).
This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days.
.