duckdb icon indicating copy to clipboard operation
duckdb copied to clipboard

`make bundle-library` doesn't work on windows

Open JAicewizard opened this issue 1 year ago • 2 comments

What happens?

The bundle-library target for make assumes the system uses the .a extension, and the location of these archives. Both of these are different on windows, the extension should be .lib, and the files are all inside a Release directory. eg: src/Release/duckdb_static.lib, third_party/*/Release/duckdb_*.lib and extension/*/Release/*_extension.lib

To Reproduce

Run make bundle-library

OS:

windows amd64 (normal github CI)

DuckDB Version:

1.0.0

DuckDB Client:

none

Full Name:

Jaap

Affiliation:

None

What is the latest build you tested with? If possible, we recommend testing with the latest nightly build.

I have tested with a source build

Did you include all relevant data sets for reproducing the issue?

Not applicable - the reproduction does not require a data set

Did you include all code required to reproduce the issue?

  • [X] Yes, I have

Did you include all relevant configuration (e.g., CPU architecture, Python version, Linux distribution) to reproduce the issue?

  • [X] Yes, I have

JAicewizard avatar Jun 17 '24 13:06 JAicewizard

Bundle-library was introduced here: https://github.com/duckdb/duckdb/pull/10507

Just for some context

Tishj avatar Jun 17 '24 13:06 Tishj

Even more issues: when using mingw on windows (mingw makefiles cmake generator) the archives are .lib.a and are located under the normal gcc paths (eg. extension/*/lib*_extension.lib.a).

JAicewizard avatar Jun 25 '24 17:06 JAicewizard

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days.

github-actions[bot] avatar Sep 24 '24 00:09 github-actions[bot]

.

JAicewizard avatar Sep 24 '24 08:09 JAicewizard