duckdb-wasm icon indicating copy to clipboard operation
duckdb-wasm copied to clipboard

Published 20 hours ago • verified publisher icon duckdb

Refactor react-duckdb

Open willium opened this issue 9 months ago • 3 comments

The existing react-duckdb providers were pretty convoluted and had properties that it didn't use. I refactored it and added documentation and comments.

I did not bump the version in package.json. This is a breaking change for this package, so I suspect it should be (part of?) a major version bump.

I may contribute some utility functions/additional hooks in the future, but these shouldn't cause breaking changes.

willium avatar May 04 '24 17:05 willium

I've been keeping an eye on these changes. It looks like they'll address some problems with race conditions in duckdb initialization. I've been holding off rewriting my connection management code because this refactor looks like a much cleaner implementation that's what's there.

Thanks for your work @willium

ncsmikewoods avatar Jun 21 '24 21:06 ncsmikewoods

This patch would be helpful to me too. Are there plans to merge and release this PR? Thanks!

jr200 avatar Sep 20 '24 07:09 jr200

I have to say I don't feel very competent to review this PR, would someone volunteer to have a deeper look?

carlopi avatar Sep 20 '24 07:09 carlopi