pymagsac icon indicating copy to clipboard operation
pymagsac copied to clipboard

src/pymagsac/include/estimators.h:83:22: error: ‘Model’ has not been declared

Open niatzt opened this issue 4 years ago • 4 comments

I am able to compile zjhthu's pymagsac: https://github.com/zjhthu/pymagsac, but failed with this version. The title shows one of the errors. I am not sure whether it is due to this version incorporating magsac++, which might cause problems somewhere.

niatzt avatar Jul 06 '20 02:07 niatzt

@niatzt I've had the same problem. Have you solved it?

justbiubiu avatar Jul 28 '20 09:07 justbiubiu

Something like this:

git clone https://github.com/danini/magsac.git
git clone https://github.com/ducha-aiki/pymagsac
cp magsac/include/estimators.h pymagsac/src/pymagsac/include/
sed -i 's@set(CMAKE_CXX_STANDARD 14)@set(CMAKE_CXX_STANDARD 17)@' pymagsac/CMakeLists.txt
cd pymagsac
python setup.py install

+ make sure you have a C++-17 compatible compiler

amonszpart avatar Jul 28 '20 15:07 amonszpart

@amonszpart 's comment worked for me, but I also had to install vtk (manjaro linux)

KlemenKobau avatar Jul 30 '20 07:07 KlemenKobau

I merged the python wrapper into the main repo (https://github.com/danini/magsac.git). Hopefully, it solved this problem as well.

danini avatar Dec 18 '20 11:12 danini