Dmytro Mishkin

Using Metric depth

1

Hi, Can I use metric depth checkpoints with provided code snippet https://github.com/LiheYoung/Depth-Anything/tree/main#import-depth-anything-to-your-project or should I only use it through the ZoeDepth methods? ```python3 from depth_anything.dpt import DPT_DINOv2 from depth_anything.util.transform import...

Add Morphology nodes from kornia

1

Adds morphology nodes (erode, dilate, etc) from kornia. Also replaces copy-paste implementation with calling kornia function for Canny. Here is screenshot how that works

kornia: why copy instead of import?

3

Hi folks, I am one of the [kornia](https://github.com/kornia/kornia) maintainers. I wonder is there any reason why you choose to copy from the kornia https://github.com/comfyanonymous/ComfyUI/blob/02409c30d9ea5314e5103d03f7c9933fa1012659/comfy_extras/nodes_canny.py#L1 instead of just importing it? If...

Inconsistent conventions in function names

8

### Describe the bug Here the points go second https://kornia.readthedocs.io/en/latest/geometry.linalg.html#kornia.geometry.linalg.transform_points Here first https://kornia.readthedocs.io/en/latest/geometry.camera.perspective.html ### Reproduction steps ```bash https://twitter.com/Parskatt/status/1754501114777456916 ``` ### Expected behavior Not be confusing. ### Environment ```shell N/a ```...

[WIP]Added multiple iterations option for the QuadInterp

4

### Description Hopefully we will have proper subpix interpolation to +/- match vlfeat and OpenCV local detector quality. ### Status **Work in progress** ### Types of changes - [] Bug...

CUDA OOM

14

Hi, The performance is really amazing on the few image pairs I have tried. However, when I moved to a bigger scenes (29 images), it crashes with CUDA OOM on...

The `R` is defined as a getter function above, so one cannot assign values to R itself, and attempts to do so breaks clang compilation. Another functions already are setting...

Crash on M1

1

Hi, I have remembered why I needed all that "FindPythonPyEnv" business. Without it, after successful compilation, I got the import crash: ``` (pytorch) dmytromishkin@Z000845-845 ~/dev python Python 3.9.16 (main, Mar...

PR to kornia?

3

Hi, Would you be interested in integrating DEAL into [kornia.features](https://kornia.readthedocs.io/en/latest/feature.html) alongside with HardNet? -- Best, Dmytro