retro-go
retro-go copied to clipboard
Retro ESP32 screen offset
Since Retro ESP32 only has Select Start, added select + A to jump to options directly
The title of your PR doesn't seem to match the description. Also the there are conflicts so I can't merge it anyway.
Right now SELECT+START should open the options on retro-esp32 but I'm fine with changing it to select+a if it's better. We could also make select+start = menu and select+a = options. Just make sure your PR is mergeable :).
I think you should start over with this PR, it should really only include rg_input.c. I think we got out of sync a bit...
I think you should start over with this PR, it should really only include rg_input.c. I think we got out of sync a bit...
If you check the Files Changed tabs it only has one file. I did a rebase before the commit
But your code is still incompatible with https://github.com/ducalex/retro-go/commit/8def604d5360fe4a6149f03ee926add5022cf021 because I removed driver 32.
You should move your change to the RG_GAMEPAD_DRIVER == 1 block instead, something like:
#ifdef RG_TARGET_RETRO_ESP32
if (state == (RG_KEY_SELECT|RG_KEY_A))
state = RG_KEY_OPTION;
if (state == (RG_KEY_START|RG_KEY_SELECT))
state = RG_KEY_MENU;
#endif
Or you can add back your driver 32 if you want but you'll have to undo some of the changes I made and update the retro-esp32.h file.
Can you also fix the title of the PR please?