Nicolas DUBIEN

Results 258 comments of Nicolas DUBIEN

On fast-check side, I think we can consider the problem as closed now that we forward the original error as-is via the official 'Error with cause' mechanism. For the moment,...

Yes, definitely. Let's open a PR. Cases we will have to check before merging anything: - how does it behave when in shrink mode? Side note: _I'm not sure that...

For tests, here is the recipe to run them locally: ```sh # from root of the repo yarn yarn build:all cd packages/fast-check # from packages/fast-check yarn test yarn e2e ```

@xtianjohns The test issue you encountered might be fixed once #3301 gets merged

I haven't seen the way you introduced it in the codebase yet, but a solution could have been to follow the pattern put in place for timeouts. In other words:...

**ava 4.3.3** 🔴 ![image](https://user-images.githubusercontent.com/5300235/191092115-313415b5-bbcd-4f8d-891c-f49810af06c4.png) **jasmine 4.4.0** 🔴 ![image](https://user-images.githubusercontent.com/5300235/191091800-d568a192-c886-4460-a874-e29d88e78397.png) **jest 28.1.2** 🔴 ![image](https://user-images.githubusercontent.com/5300235/191091921-40390cd2-c6ce-44b3-a36a-712f0adda8d7.png) **mocha 10.0.0** 🔴 ![image](https://user-images.githubusercontent.com/5300235/191092260-84f719e7-c3d6-483c-852c-b2a6d775361f.png) **node 16.14.0** 🟢 ![image](https://user-images.githubusercontent.com/5300235/191092586-0fabb5ad-ffe8-4691-9f8d-e9aa39dbb23b.png) **vitest 0.17.0** 🟢 ![image](https://user-images.githubusercontent.com/5300235/191092480-2ee86ea2-feb6-40bd-9c2b-d5a7a599c8c8.png)

With the new flag against vitest: ![image](https://user-images.githubusercontent.com/5300235/191337899-abe3cea7-0e95-43b7-b677-9607db766607.png) ![image](https://user-images.githubusercontent.com/5300235/191337805-bc6ffc43-7523-44e1-92da-e147c7418d88.png) Code snippet ```js import { test, expect } from "vitest"; import fc from "fast-check"; fc.configureGlobal({ errorWithCause: true }); test("error cause", () =>...

@jasikpark FYI https://github.com/vitest-dev/vitest/discussions/2212

Closing this issue as the recent merge of https://github.com/dubzzz/fast-check/pull/2965 which makes 'Error with cause' something possible is probably the way to go. Not having to copy the original error within...